This is a very easy good first bug for a beginner. The following return; declarations are useless as we are at the end of the function/method https://dxr.mozilla.org/mozilla-central/source/widget/gtk/nsWindow.cpp?q=widget%2Fgtk%2FnsWindow.cpp&redirect_type=direct#1134 https://dxr.mozilla.org/mozilla-central/source/widget/gtk/nsWindow.cpp?q=widget%2Fgtk%2FnsWindow.cpp&redirect_type=direct#1164

Comment on attachment 8831514 [details] Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type. Good work, now please find a reviewer: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed

Thanks for assigning the bug. Will you be willing to review it if I add you as a reviewer?

You need to find a component owner: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed

Comment on attachment 8831514 [details] Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type. https://reviewboard.mozilla.org/r/108070/#review111778 ::: widget/gtk/nsWindow.cpp (Diff revision 1) > > if (mIsTopLevel || mListenForResizes) { > DispatchResized(); > } > - > - return; > removed two redundant return statements at the end of a function with a void return type Please use imperative mood instead of indicative, and make "end" and "function" plural. "remove two redundant return statements at the ends of functions with void return type"

Comment on attachment 8831514 [details] Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type. I don't know why mozreview removed the f+ and r+, sorry.

Hello I am a new developer.Can I work on this bug?

Sorry but someone has been working on this already.

Is there anything else to do, like adding tests?

You should mark Karl's comment as "Fixed" in the review: https://reviewboard.mozilla.org/r/108070/#issue-summary Then, either do: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_6_-_Actually_get_the_code_into_the_tree Or ask me to land it for you through mozreview & autoland (I cannot do it for you as you haven't closed the review)

Marked the comment as "Fixed". A small query,is the marking done to ensure that the person working on it has fixed the reopened issue?

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9e21c2dc1b0d nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type. r=karlt